tDOM: View Ticket

Ticket Hash:	33972ca1bba1e689f104b47699d3846adbe23812
Title:	tDOM Makefile.in templates do not pull in custom LDFLAGS from configure run
Status:	Closed	Type:	Build_Problem
Severity:	Minor	Priority:	Immediate
Subsystem:		Resolution:	Fixed
Last Modified:	2021-06-01 22:40:07
Version Found In:	0.9.2
User Comments:
anonymous added on 2021-05-29 17:06:26: Hi. While updating my SlackBuild script for tDOM (http://slackbuilds.org/repository/14.2/libraries/tDOM/) today to build version 0.9.2 I encountered a link issue with tnc. I am passing in a link location via LDFLAGS= to configure with a path to the SlackBuild directory where the tdom stubs library was found, but the linker was never receiving the -L incantation. I traced the problem down to the Makefile.in templates omitting a LDFLAGS = @LDFLAGS@ stanza. Adding that stanza to all of the Makefile.in templates provided a proper build and Slackware install package from the process. I have a patch file, but I don't see any way to "attach a file" so I'll just copy/paste the contents below, hopefully the patch will survive the process (although the patch is trivial in any case). diff -u -r tdom-0.9.2-src.orig/Makefile.in tdom-0.9.2-src/Makefile.in --- tdom-0.9.2-src.orig/Makefile.in 2020-08-27 12:32:27.000000000 -0400 +++ tdom-0.9.2-src/Makefile.in 2021-05-29 12:22:49.377664267 -0400 @@ -180,6 +180,7 @@ LIBS = @PKG_LIBS@ @LIBS@ AR = @AR@ CFLAGS = @CFLAGS@ +LDFLAGS = @LDFLAGS@ COMPILE = $(CC) $(DEFS) $(INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS) $(AM_CFLAGS) $(CFLAGS) GDB = gdb diff -u -r tdom-0.9.2-src.orig/extensions/example/Makefile.in tdom-0.9.2-src/extensions/example/Makefile.in --- tdom-0.9.2-src.orig/extensions/example/Makefile.in 2020-08-27 12:32:27.000000000 -0400 +++ tdom-0.9.2-src/extensions/example/Makefile.in 2021-05-29 12:22:48.225694702 -0400 @@ -165,6 +165,7 @@ LIBS = @PKG_LIBS@ @LIBS@ AR = @AR@ CFLAGS = @CFLAGS@ +LDFLAGS = @LDFLAGS@ COMPILE = $(CC) $(DEFS) $(INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS) $(AM_CFLAGS) $(CFLAGS) .SUFFIXES: .c .$(OBJEXT) diff -u -r tdom-0.9.2-src.orig/extensions/schemadtx/Makefile.in tdom-0.9.2-src/extensions/schemadtx/Makefile.in --- tdom-0.9.2-src.orig/extensions/schemadtx/Makefile.in 2020-08-27 12:32:27.000000000 -0400 +++ tdom-0.9.2-src/extensions/schemadtx/Makefile.in 2021-05-29 12:22:47.649709919 -0400 @@ -165,6 +165,7 @@ LIBS = @PKG_LIBS@ @LIBS@ AR = @AR@ CFLAGS = @CFLAGS@ +LDFLAGS = @LDFLAGS@ COMPILE = $(CC) $(DEFS) $(INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS) $(AM_CFLAGS) $(CFLAGS) .SUFFIXES: .c .$(OBJEXT) diff -u -r tdom-0.9.2-src.orig/extensions/tdomhtml/Makefile.in tdom-0.9.2-src/extensions/tdomhtml/Makefile.in --- tdom-0.9.2-src.orig/extensions/tdomhtml/Makefile.in 2020-08-27 12:32:27.000000000 -0400 +++ tdom-0.9.2-src/extensions/tdomhtml/Makefile.in 2021-05-29 12:22:46.985727462 -0400 @@ -116,6 +116,7 @@ AR = ar CFLAGS = @CFLAGS@ +LDFLAGS = @LDFLAGS@ COMPILE = $(CC) $(DEFS) $(INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS) $(AM_CFLAGS) $(CFLAGS) #======================================================================== diff -u -r tdom-0.9.2-src.orig/extensions/tnc/Makefile.in tdom-0.9.2-src/extensions/tnc/Makefile.in --- tdom-0.9.2-src.orig/extensions/tnc/Makefile.in 2020-08-27 12:32:27.000000000 -0400 +++ tdom-0.9.2-src/extensions/tnc/Makefile.in 2021-05-29 12:22:48.817679062 -0400 @@ -165,6 +165,7 @@ LIBS = @PKG_LIBS@ @LIBS@ AR = @AR@ CFLAGS = @CFLAGS@ +LDFLAGS = @LDFLAGS@ COMPILE = $(CC) $(DEFS) $(INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS) $(AM_CFLAGS) $(CFLAGS) .SUFFIXES: .c .$(OBJEXT) rolf added on 2021-06-01 22:40:07: Thanks for the report. Fixed accordingly. (Turned out, that TEA - which missed that line in the version, I worked the tDOM build files from - has the same fix, since a while.)