Overview

Artifact ID: 50301e599a51d780bc33aa12717274798fd86c7085a01c9c5c78b988329780e9
Ticket: 33972ca1bba1e689f104b47699d3846adbe23812
tDOM Makefile.in templates do not pull in custom LDFLAGS from configure run
User & Date: anonymous 2021-05-29 17:06:26
Changes

  1. foundin changed to: "0.9.2"
  2. icomment:
    Hi.  While updating my SlackBuild script for tDOM (http://slackbuilds.org/repository/14.2/libraries/tDOM/) today to build version 0.9.2 I encountered a link issue with tnc.  I am passing in a link location via LDFLAGS= to configure with a path to the SlackBuild directory where the tdom stubs library was found, but the linker was never receiving the -L incantation.
    
    I traced the problem down to the Makefile.in templates omitting a LDFLAGS = @LDFLAGS@ stanza.  Adding that stanza to all of the Makefile.in templates provided a proper build and Slackware install package from the process.
    
    I have a patch file, but I don't see any way to "attach a file" so I'll just copy/paste the contents below, hopefully the patch will survive the process (although the patch is trivial in any case).
    
    diff -u -r tdom-0.9.2-src.orig/Makefile.in tdom-0.9.2-src/Makefile.in
    --- tdom-0.9.2-src.orig/Makefile.in	2020-08-27 12:32:27.000000000 -0400
    +++ tdom-0.9.2-src/Makefile.in	2021-05-29 12:22:49.377664267 -0400
    @@ -180,6 +180,7 @@
     LIBS		= @PKG_LIBS@ @LIBS@
     AR		= @AR@
     CFLAGS		= @CFLAGS@
    +LDFLAGS		= @LDFLAGS@
     COMPILE		= $(CC) $(DEFS) $(INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS) $(AM_CFLAGS) $(CFLAGS)
     
     GDB		= gdb
    diff -u -r tdom-0.9.2-src.orig/extensions/example/Makefile.in tdom-0.9.2-src/extensions/example/Makefile.in
    --- tdom-0.9.2-src.orig/extensions/example/Makefile.in	2020-08-27 12:32:27.000000000 -0400
    +++ tdom-0.9.2-src/extensions/example/Makefile.in	2021-05-29 12:22:48.225694702 -0400
    @@ -165,6 +165,7 @@
     LIBS		= @PKG_LIBS@ @LIBS@
     AR		= @AR@
     CFLAGS		= @CFLAGS@
    +LDFLAGS		= @LDFLAGS@
     COMPILE		= $(CC) $(DEFS) $(INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS) $(AM_CFLAGS) $(CFLAGS)
     
     .SUFFIXES: .c .$(OBJEXT)
    diff -u -r tdom-0.9.2-src.orig/extensions/schemadtx/Makefile.in tdom-0.9.2-src/extensions/schemadtx/Makefile.in
    --- tdom-0.9.2-src.orig/extensions/schemadtx/Makefile.in	2020-08-27 12:32:27.000000000 -0400
    +++ tdom-0.9.2-src/extensions/schemadtx/Makefile.in	2021-05-29 12:22:47.649709919 -0400
    @@ -165,6 +165,7 @@
     LIBS		= @PKG_LIBS@ @LIBS@
     AR		= @AR@
     CFLAGS		= @CFLAGS@
    +LDFLAGS		= @LDFLAGS@
     COMPILE		= $(CC) $(DEFS) $(INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS) $(AM_CFLAGS) $(CFLAGS)
     
     .SUFFIXES: .c .$(OBJEXT)
    diff -u -r tdom-0.9.2-src.orig/extensions/tdomhtml/Makefile.in tdom-0.9.2-src/extensions/tdomhtml/Makefile.in
    --- tdom-0.9.2-src.orig/extensions/tdomhtml/Makefile.in	2020-08-27 12:32:27.000000000 -0400
    +++ tdom-0.9.2-src/extensions/tdomhtml/Makefile.in	2021-05-29 12:22:46.985727462 -0400
    @@ -116,6 +116,7 @@
     AR		= ar
     
     CFLAGS		= @CFLAGS@
    +LDFLAGS		= @LDFLAGS@
     COMPILE		= $(CC) $(DEFS) $(INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS) $(AM_CFLAGS) $(CFLAGS)
     
     #========================================================================
    diff -u -r tdom-0.9.2-src.orig/extensions/tnc/Makefile.in tdom-0.9.2-src/extensions/tnc/Makefile.in
    --- tdom-0.9.2-src.orig/extensions/tnc/Makefile.in	2020-08-27 12:32:27.000000000 -0400
    +++ tdom-0.9.2-src/extensions/tnc/Makefile.in	2021-05-29 12:22:48.817679062 -0400
    @@ -165,6 +165,7 @@
     LIBS		= @PKG_LIBS@ @LIBS@
     AR		= @AR@
     CFLAGS		= @CFLAGS@
    +LDFLAGS		= @LDFLAGS@
     COMPILE		= $(CC) $(DEFS) $(INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS) $(AM_CFLAGS) $(CFLAGS)
     
     .SUFFIXES: .c .$(OBJEXT)
    
  3. login: "anonymous"
  4. mimetype: "text/plain"
  5. private_contact changed to: "4fc15a9fd36528d4bf38dcb7fcef28bbd405fde3"
  6. severity changed to: "Minor"
  7. status changed to: "Open"
  8. title changed to:
    tDOM Makefile.in templates do not pull in custom LDFLAGS from configure run
    
  9. type changed to: "Build_Problem"